Add modifier for "fun interface" #393
Milestone
Comments
ting-yuan
added
api
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this issue
May 18, 2021
## Proposed Changes Adds an interface function to get element kdoc. Implements this for javac, and uses null for KSP until google/ksp#392 is fixed Also surfaces more XTypeElement information, such as whether the type is a data class, a fun interface, a companion object, etc. I implemented everything exposed in kotlin class metadata that seemed reasonable in order to future proof it a bit. I was not able to implement fun interface checking for KSP since it is not yet surfaced in KSP - google/ksp#393 ## Testing Test: Added cases to XTypeElementTest.modifiers Note, I wasn't able to test the `expect` modifier. First I had to add support for custom compiler arguments so I could enable multiplatform via `"-Xmulti-platform"` but to get the test sources to compile I had to include a `actual` implementation as well, and since both the expected and actual implementations were in the same sources it seems the processor only picks up the actual. Omitting "actual" implementation doesn't work as compilation fails with "no actual implementation found in module", and I'm not sure how to have the compiler processing testing work with multiple module sources. The implementation of the "expect" modifier is very simple so I'm not sure how important the test is. ## Issues Fixed Fixes: https://issuetracker.google.com/issues/185672887 This is an imported pull request from #164. Resolves #164 Github-Pr-Head-Sha: 0bcd0af GitOrigin-RevId: 04f408a Change-Id: Ifcf6b7aac73643866034e4bb2e95df81ee997b72
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this issue
May 21, 2021
Update XProcessing to take advantage of the new ORIGIN types: google/ksp#375 Added support for doc comments in KSP google/ksp#392 Added support for fun interfaces in KSP google/ksp#393 Removed custom KCT workaround with the update to KCT 1.4.0 With this update we also get access to the containing class declaration for compiled top level kotlin functions. That change is more complicated so added a bug for that as a followup: b/188822146. We also now have access to a type mapper between java and kotlin classes but it is not working as we expect so will skip that update for now. Specifically, it does not support primitives and it also maps java classes to their immutable counterparts (e.g. java.util.List to kotlin.collections.List instead of MutableList) Last but not least, also updated incremental processing test to specify room version explicitly instead of +. It becomes a problem in playground where androidx.snapshot repository has a higher version value (SNAPSHOT) then local publish task. Bug: 160322705 Bug: 188822146 Test: room tests Change-Id: I0bc03621bc0727fc94fba58c7c4e2cdbb254424d
olonho
pushed a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
May 25, 2021
## Proposed Changes Adds an interface function to get element kdoc. Implements this for javac, and uses null for KSP until google/ksp#392 is fixed Also surfaces more XTypeElement information, such as whether the type is a data class, a fun interface, a companion object, etc. I implemented everything exposed in kotlin class metadata that seemed reasonable in order to future proof it a bit. I was not able to implement fun interface checking for KSP since it is not yet surfaced in KSP - google/ksp#393 ## Testing Test: Added cases to XTypeElementTest.modifiers Note, I wasn't able to test the `expect` modifier. First I had to add support for custom compiler arguments so I could enable multiplatform via `"-Xmulti-platform"` but to get the test sources to compile I had to include a `actual` implementation as well, and since both the expected and actual implementations were in the same sources it seems the processor only picks up the actual. Omitting "actual" implementation doesn't work as compilation fails with "no actual implementation found in module", and I'm not sure how to have the compiler processing testing work with multiple module sources. The implementation of the "expect" modifier is very simple so I'm not sure how important the test is. ## Issues Fixed Fixes: https://issuetracker.google.com/issues/185672887 This is an imported pull request from androidx#164. Resolves #164 Github-Pr-Head-Sha: 0bcd0af GitOrigin-RevId: 04f408a Change-Id: Ifcf6b7aac73643866034e4bb2e95df81ee997b72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Support the language feature "function SAM interfaces" - https://kotlinlang.org/docs/fun-interfaces.html
As far as I can tell
com.google.devtools.ksp.symbol.Modifierdoesn't have an entry for this and there is currently no way to check this on an KSClassDeclaration.It seems like this would be fairly straightforward to do?
ModifierenumClassDescriptor.isFunmodifierMapThe text was updated successfully, but these errors were encountered: