Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

released POM files do not list dependencies #187

Closed
yigit opened this issue Dec 9, 2020 · 1 comment
Closed

released POM files do not list dependencies #187

yigit opened this issue Dec 9, 2020 · 1 comment
Assignees
@ting-yuan
Labels
bug Something isn't working P1 major features or blocking bugs
Milestone
Alpha

Comments

@yigit
Copy link
Collaborator

yigit commented Dec 9, 2020

I noticed this after hitting some class not found exceptions after an upgrade.
turns out, the pom files are missing dependencies and it was pulling kotlin compiler embeddable 1.4.10 instead of 1.4.20 for tests. (1.4.10 comes from kotlin compile testing's dependencies)

Is this intentional?
https://dl.google.com/android/maven2/com/google/devtools/ksp/symbol-processing/1.4.20-dev-experimental-20201204/symbol-processing-1.4.20-dev-experimental-20201204.pom
@ting-yuan ting-yuan self-assigned this Dec 10, 2020
@ting-yuan ting-yuan added bug Something isn't working P1 major features or blocking bugs labels Dec 10, 2020
@ting-yuan ting-yuan modified the milestones: 2021Q1, alpha Dec 31, 2020
@ting-yuan ting-yuan mentioned this issue Jan 6, 2021
Merged
@ting-yuan
Copy link
Collaborator

Fixed in #233

copybara-service bot pushed a commit to androidx/androidx that referenced this issue Apr 12, 2021
@yigit
Remove ksp issue link for google/ksp#187
6bb8f24 
KSP used to not specify kotlin compiler dependencies in pom files so we
added them manually. Now KSP does this correctly but it is best to keep
them to ensure we use the right compiler version that is used in
AndroidX, not in KSP.

google/ksp#187

Bug: 160322705
Test: existing tests
Change-Id: Ia2c2dc5e8b68bb604abb08703396e0d5fb425539
copybara-service bot pushed a commit to androidx/androidx that referenced this issue Apr 12, 2021
Merge "Remove ksp issue link for google/ksp#187" into androidx-main
e68969c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ting-yuan ting-yuan

Labels
bug Something isn't working P1 major features or blocking bugs
Projects
None yet
Milestone
Alpha
Development

No branches or pull requests
2 participants
@yigit @ting-yuan