Skip to content

Commit

Permalink
Fix dependencies
Browse files Browse the repository at this point in the history
Although gradle-plugin/ and compiler-plugin/ depend on KGP and Kotlin
compiler, they are always loaded and should not pull the dependencies
actively.
  • Loading branch information
ting-yuan committed Jul 20, 2023
1 parent f1724b5 commit 1fef366
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ plugins {
}

dependencies {
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin-api:$kotlinBaseVersion")
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinBaseVersion")
compileOnly("org.jetbrains.kotlin:kotlin-gradle-plugin-api:$kotlinBaseVersion")
compileOnly("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinBaseVersion")
compileOnly("org.jetbrains.kotlin:kotlin-compiler-embeddable:$kotlinBaseVersion")
// replace AGP dependency w/ gradle-api when we have source registering API available.
compileOnly("com.android.tools.build:gradle:$agpBaseVersion")
Expand Down
1 change: 1 addition & 0 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ pluginManagement {
repositories {
gradlePluginPortal()
maven("https://maven.pkg.jetbrains.space/kotlin/p/kotlin/bootstrap/")
maven("https://www.jetbrains.com/intellij-repository/snapshots")
}
}

Expand Down
1 change: 0 additions & 1 deletion symbol-processing-cmdline/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ publishing {

asNode().appendNode("dependencies").apply {
addDependency("org.jetbrains.kotlin", "kotlin-stdlib", kotlinBaseVersion)
addDependency("org.jetbrains.kotlin", "kotlin-compiler", kotlinBaseVersion)
addDependency("com.google.devtools.ksp", "symbol-processing-api", version)
}
}
Expand Down
1 change: 0 additions & 1 deletion symbol-processing/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ publishing {

asNode().appendNode("dependencies").apply {
addDependency("org.jetbrains.kotlin", "kotlin-stdlib", kotlinBaseVersion)
addDependency("org.jetbrains.kotlin", "kotlin-compiler-embeddable", kotlinBaseVersion)
addDependency("com.google.devtools.ksp", "symbol-processing-api", version)
}
}
Expand Down

0 comments on commit 1fef366

Please sign in to comment.