Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to fix play item by index #494

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Aug 16, 2022

WHAT

Workaround to fix play item by index until issue androidx/media#85 is fixed in media3.

Fixes #495

WHY

So the app can play the specific song selected by the user.

HOW

  • Add a delay after call to setMediaList

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp luizgrp force-pushed the mediasample_play_item_fix branch 2 times, most recently from 714b473 to 1ae7242 Compare August 16, 2022 15:40
@luizgrp luizgrp marked this pull request as ready for review August 16, 2022 15:43
@luizgrp luizgrp merged commit f5b3b08 into google:main Aug 16, 2022
@luizgrp luizgrp deleted the mediasample_play_item_fix branch August 16, 2022 16:30
luizgrp added a commit that referenced this pull request Aug 16, 2022
luizgrp added a commit that referenced this pull request Aug 16, 2022
@luizgrp luizgrp requested review from yschimke and removed request for yschimke August 22, 2022 10:50
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is no longer relevant.

@luizgrp luizgrp self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media sample doesn't play song at specific index
2 participants