Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RF64 wave files #9543

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Add support for RF64 wave files #9543

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55a86b8
Add support for RF64 wave files
KasemJaffer Oct 5, 2021
8501e99
Fix wrong RF64 data size and add unit test
KasemJaffer Oct 15, 2021
69b2dd0
Change condition to not log warning for RF64 files
KasemJaffer Oct 15, 2021
5b05d64
Add RF64 dump files for testing
KasemJaffer Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change condition to not log warning for RF64 files
  • Loading branch information
@KasemJaffer
KasemJaffer committed Oct 15, 2021
commit 69b2dd0fbf10930a0d567b892e5e53a07189e46b
3 changes: 2 additions & 1 deletion .../extractor/src/main/java/com/google/android/exoplayer2/extractor/wav/WavHeaderReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ public static Pair<Long, Long> skipToData(ExtractorInput input) throws IOExcepti
long dataSize = -1;

while (chunkHeader.id != WavUtil.DATA_FOURCC) {
if (chunkHeader.id != WavUtil.RIFF_FOURCC && chunkHeader.id != WavUtil.FMT_FOURCC) {
if (chunkHeader.id != WavUtil.RIFF_FOURCC && chunkHeader.id != WavUtil.FMT_FOURCC
&& chunkHeader.id != WavUtil. RF64_FOURCC && chunkHeader.id != WavUtil. DS64_FOURCC) {
Log.w(TAG, "Ignoring unknown WAV chunk: " + chunkHeader.id);
}
long bytesToSkip = ChunkHeader.SIZE_IN_BYTES + chunkHeader.size;
Expand Down