Ignore invalid RTP-Info header value.

Issue: #9619 (and a few other GH issues related to invalid RTP-Info header) PiperOrigin-RevId: 423283017
google · Jan 25, 2022 · cd076f7 · cd076f7
1 parent 5a60db3
commit cd076f7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -110,6 +110,8 @@
         ([#9800](https://github.com/google/ExoPlayer/issues/9800)).
     *   Handle when RTSP track timing is not available
         ([#9775](https://github.com/google/ExoPlayer/issues/9775)).
+    *   Ignores invalid RTP-Info header values
+        ([#9619](https://github.com/google/ExoPlayer/issues/9619)).
 *   Cast extension
     *   Fix bug that prevented `CastPlayer` from calling `onIsPlayingChanged`
         correctly ([#9792](https://github.com/google/ExoPlayer/issues/9792)).

diff --git a/library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java b/library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java
@@ -619,11 +619,18 @@ private void handleRtspResponse(List<String> message) {
                 startTimingString == null
                     ? RtspSessionTiming.DEFAULT
                     : RtspSessionTiming.parseTiming(startTimingString);
-            @Nullable String rtpInfoString = response.headers.get(RtspHeaders.RTP_INFO);
-            ImmutableList<RtspTrackTiming> trackTimingList =
-                rtpInfoString == null
-                    ? ImmutableList.of()
-                    : RtspTrackTiming.parseTrackTiming(rtpInfoString, uri);
+
+            ImmutableList<RtspTrackTiming> trackTimingList;
+            try {
+              @Nullable String rtpInfoString = response.headers.get(RtspHeaders.RTP_INFO);
+              trackTimingList =
+                  rtpInfoString == null
+                      ? ImmutableList.of()
+                      : RtspTrackTiming.parseTrackTiming(rtpInfoString, uri);
+            } catch (ParserException e) {
+              trackTimingList = ImmutableList.of();
+            }
+
             onPlayResponseReceived(new RtspPlayResponse(response.status, timing, trackTimingList));
             break;