-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New examples should be listed in the table of content. #239
Merged
MarkDaoust
merged 16 commits into
google-gemini:main
from
Giom-V:new_examples_links_in_examples_table_of_content
Jul 17, 2024
Merged
New examples should be listed in the table of content. #239
MarkDaoust
merged 16 commits into
google-gemini:main
from
Giom-V:new_examples_links_in_examples_table_of_content
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince the readme hasn't been updated.
Giom-V
changed the title
New examples links in examples table of content
New exemples should be listed in the table of content.
Jul 11, 2024
Giom-V
changed the title
New exemples should be listed in the table of content.
New examples should be listed in the table of content.
Jul 11, 2024
MarkDaoust
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if new examples are added, and then verify that links to them have been added in the examples README's table of content.
The current script only works with the examples folder so we can iterate on it but when it will work I plan to also add a similar workflow for the quickstart folder and also one that checks if the "what's new' section of the main README is also updated.
I'll create fake commits by adding new files, editing them and deleting them to verify if the script works as expected. Squashing should make all those updates disappear from the history.