Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Introduce Gradle Version Catalog #132

Merged
merged 10 commits into from
Mar 3, 2023
Merged

Introduce Gradle Version Catalog #132

merged 10 commits into from
Mar 3, 2023

Conversation

kaibernhard
Copy link
Contributor

No description provided.

kaibernhard
kaibernhard commented Feb 22, 2023
View reviewed changes
app/build.gradle
@@ -139,7 +139,7 @@ android {
compose true
}
composeOptions {
kotlinCompilerExtensionVersion compose_version
kotlinCompilerExtensionVersion libs.versions.compose.compiler.get()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compose compiler is bound to Kotlin version, not Compose version - see https://developer.android.com/jetpack/androidx/releases/compose-kotlin

app/build.gradle
@@ -150,78 +150,58 @@ android {
textReport true
}
namespace 'de.digitalService.useID'
applicationVariants.all { variant ->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration of source sets for KSP generated code is not needed any more with latest KSP plugin

gradle/libs.versions.toml
androidx-test-core = "androidx.test:core:1.5.0-rc01"
androidx-test-espresso-core = "androidx.test.espresso:espresso-core:3.5.1"
androidx-test-ext-junit = "androidx.test.ext:junit:1.1.5"
compose-bom = "androidx.compose:compose-bom:2023.01.00"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compose bill of materials is now the recommended way to use the latest stable versions of compose dependencies since they will be versioned independently, see https://developer.android.com/jetpack/compose/bom/bom

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like that!

@FabioTacke
Copy link
Contributor

The CI seems to fail due to a bug in the exoplayer library.
So maybe we should stay on the previous version for now and emphasize again that the video is just a workaround for the buggy animation that we want to replace at some point anyway with a proper one.

@kaibernhard
Copy link
Contributor Author

If I understand the conversation in the GitHub issue correctly, only apps using DownloadService need to add this permission to their manifest and request the permission at runtime. The issue is classified as a bug in their demo app, not in the library, so the issue will not be fixed for us by future updates. Reverting the update of ExoPlayer dependency does not solve the CI failure either - it was triggered by updating AGP plugin which introduced a new lint check. Since we don't use DownloadService, there is no need to include the permission in the manifest nor request the permission at runtime. I would propose to exclude the lint check specifically for the notification in ExoPlayer's DownloadService via lint.xml.

@mhernand40 mhernand40 mentioned this pull request Feb 28, 2023
Open
@kaibernhard
Introduce Gradle Version Catalog
6be439a
@kaibernhard
Update Kotlin, Compose Compiler, KSP, AGP and Hilt
bcf0bcd 
* Kotlin 1.8.10
* Compose Compiler 1.4.2
* KSP 1.8.10-1.0.9
* Android Gradle Plugin 7.4.1
* Hilt 2.44.2

SourceSets configuration for KSP is not needed any more with latest
KSP plugin.
@kaibernhard
Use Compose BOM
09a0417 
See https://developer.android.com/jetpack/compose/bom/bom
@kaibernhard
Configure dependency updates to reject non-stable versions
6e71194
@kaibernhard
Update dependencies, pin compose-markdown
06d132d
@kaibernhard
Reorder dependencies by (kapt/ksp/implementation/debug/test/androidTest)
8171cee 
The androidTestAnnotationProcessor for Hilt has been removed.
@kaibernhard
Ignore some incorrect/irrelevant lint issues
b7a9535
@kaibernhard
Pin mockk dependency
b3ba0ff 
The latest version triggers IncompatibleClassChangeError.
@kaibernhard
Update compose compiler and dependencies
3875e76
@kaibernhard
Update Android Gradle Plugin (7.4.2)
7d0d252
@kaibernhard kaibernhard merged commit 7d0d252 into main Mar 3, 2023
@kaibernhard kaibernhard deleted the gradle-version-catalog branch March 3, 2023 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabioTacke FabioTacke FabioTacke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaibernhard @FabioTacke