CI: make 710-kube parallel-safe #23921
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
test/system/710-kube.bats
Outdated
| @@ -19,15 +20,18 @@ json.dump(yaml.safe_load(sys.stdin), sys.stdout)' | |||
| ############################################################################### | |||
| # BEGIN tests | |||
|
|
|||
| # bats test_tags=ci:parallel | |||
There was a problem hiding this comment.
All tests in this file have the ci:parallel tag. I am tempted to remove them all, and add it at top using file_tags, because (IMO) the tests here should always be parallel-safe, including future additions. IOW I prefer this risk:
- new test gets added, it runs (by default) in parallel but somehow it was not written properly nor reviewed properly and we get new flakes
over: - new test gets added, but we all forget to add/review the
ci:paralleltag, so it runs serial by default, slowing down the world.
Opinions welcome.
There was a problem hiding this comment.
I would default to parallel. Flakes might show up, but we should be able to find them quickly.
Podman by default runs i parallel by design, so better to default to it.
|
LGTM either way. |
Use safename. Add ci:parallel tags. Use a random port, not hardcoded 9999. Do not remove pause image. And especially do not "rm -a" anything. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
force-pushed
the
safename-710
branch
from
b168eb6
to
e61682f
Compare
|
/lgtm |
Use safename. Add ci:parallel tags. Use a random port, not
hardcoded 9999. Do not remove pause image. And especially
do not "rm -a" anything.
Signed-off-by: Ed Santiago santiago@redhat.com