fix(traversing): parent() may fail in functions (#1637)

cheeriojs · Jan 4, 2021 · 43592d6 · 43592d6
1 parent b6d3840
commit 43592d6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/api/traversing.js b/lib/api/traversing.js
@@ -86,7 +86,7 @@ exports.parent = function (selector) {
     }
   });
 
-  if (arguments.length) {
+  if (selector) {
     set = exports.filter.call(set, selector, this);
   }
 

diff --git a/test/api/traversing.js b/test/api/traversing.js
@@ -619,6 +619,12 @@ describe('$(...)', function () {
       expect(result[1].attribs.id).toBe('vegetables');
     });
 
+    it('(undefined) : should not throw an exception', function () {
+      expect(function () {
+        $('li').parent(undefined);
+      }).not.toThrow();
+    });
+
     it('() : should return an empty object for top-level elements', function () {
       var result = $('html').parent();
       expect(result).toHaveLength(0);