Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish animation ignoring cancellation. #5279

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

kanelbulle
Copy link
Collaborator

@kanelbulle kanelbulle commented Sep 14, 2023

Fixes #5278

Invokes the animation finish non-cancellable in case the coroutine has been cancelled. Without it I think there's a risk we might leave something half-animated. Even if that can't practically happen, I believe this is best practice.

@sjudd
Copy link
Collaborator

sjudd commented Sep 19, 2023

Thanks!

@sjudd sjudd merged commit 06fc8f6 into bumptech:master Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition.kt invokes cancellable suspend function in finally clause
2 participants