Use an HTTP registry in Bzlmod tests #21906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for tracking the hashes of remote (non-`file:` URL) files in the lockfile. Work towards bazelbuild#20369
fmeum
commented
Apr 5, 2024
| @@ -29,6 +29,7 @@ def setUp(self): | |||
| self.main_registry = BazelRegistry( | |||
| os.path.join(self.registries_work_dir, 'main') | |||
| ) | |||
| self.main_registry.start() | |||
There was a problem hiding this comment.
Is there a way to adapt a with-able object for use in setUp/tearDown style function?
github-actions
bot
added
team-ExternalDeps
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.2.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 5, 2024
This is in preparation for tracking the hashes of remote (non-`file:` URL) files in the lockfile. If the tests use local registries, they wouldn't be representative of the default situation. Work towards bazelbuild#20369 Closes bazelbuild#21906. PiperOrigin-RevId: 622290283 Change-Id: Ibe825d2bede84c1b0672dbb699aaf3ee5168a813
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
This is in preparation for tracking the hashes of remote (non-`file:` URL) files in the lockfile. If the tests use local registries, they wouldn't be representative of the default situation. Work towards #20369 Closes #21906. PiperOrigin-RevId: 622290283 Change-Id: Ibe825d2bede84c1b0672dbb699aaf3ee5168a813 Commit 3f9d80c Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
sgowroji
removed
the
awaiting-PR-merge
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
This is in preparation for tracking the hashes of remote (non-`file:` URL) files in the lockfile. If the tests use local registries, they wouldn't be representative of the default situation. Work towards bazelbuild#20369 Closes bazelbuild#21906. PiperOrigin-RevId: 622290283 Change-Id: Ibe825d2bede84c1b0672dbb699aaf3ee5168a813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for tracking the hashes of remote (non-
file:URL) files in the lockfile. If the tests use local registries, they wouldn't be representative of the default situation.Work towards #20369