Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store usages hash in module extension lockfile entries #21408

Closed
wants to merge 2 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 19, 2024

Prepare for the removal of the extension usages section of the lockfile by storing the usages fed into each extension as a hash.

Implements part of https://docs.google.com/document/d/1TjA7-M5njkI1F38IC0pm305S9EOmxcUwaCIvaSmansg/edit
Work towards #20369

@fmeum fmeum force-pushed the 20369-usages-hash branch 2 times, most recently from ffffd7c to 7b64665 Compare February 19, 2024 13:00
@fmeum fmeum force-pushed the 20369-usages-hash branch 2 times, most recently from e1999ea to 380d44c Compare March 27, 2024 15:29
@fmeum fmeum marked this pull request as ready for review March 27, 2024 15:42
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Mar 27, 2024
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 28, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Mar 28, 2024

@bazel-io flag 7.2.0

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 28, 2024
@iancha1992
Copy link
Member

@bazel-io fork 7.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 28, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 28, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Mar 28, 2024
Prepare for the removal of the extension usages section of the lockfile by storing the usages fed into each extension as a hash.

Implements part of https://docs.google.com/document/d/1TjA7-M5njkI1F38IC0pm305S9EOmxcUwaCIvaSmansg/edit
Work towards bazelbuild#20369

Closes bazelbuild#21408.

PiperOrigin-RevId: 620014723
Change-Id: Ie781cee702ec4071710ba47a8635e0b039ea28e8
Wyverald pushed a commit that referenced this pull request Mar 28, 2024
Prepare for the removal of the extension usages section of the lockfile
by storing the usages fed into each extension as a hash.

Implements part of
https://docs.google.com/document/d/1TjA7-M5njkI1F38IC0pm305S9EOmxcUwaCIvaSmansg/edit
Work towards #20369

Closes #21408.

PiperOrigin-RevId: 620014723
Change-Id: Ie781cee702ec4071710ba47a8635e0b039ea28e8

Commit
87b53ab

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum fmeum deleted the 20369-usages-hash branch March 29, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants