Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print combined progress when pulling #31

Merged
merged 2 commits into from
Oct 4, 2017

Conversation

petrosagg
Copy link
Contributor

No description provided.

This Sink can have multiple writers writing to it so that it calculates
a progress for all of them. For example, if you are downloading 5 files,
1, 2, 3, 4, 5 MB each, you can create a ProgressSink with its size set
to 15MB and use io.Tee() with each of those files' Readers to calculate
a combined progress.

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg petrosagg requested a review from zozo123 October 3, 2017 23:17
Copy link
Contributor

@zozo123 zozo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please consider to add a unit test for progresssink.go

@petrosagg petrosagg merged commit 7d07e4f into 17.06-resin Oct 4, 2017
@petrosagg petrosagg deleted the pull-combined-progress branch October 4, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants