r1.0.0 beta01 #88
Merged
r1.0.0 beta01 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 444253425
PiperOrigin-RevId: 444264961
*** Original commit *** Keep AudioTrack on flush as default *** PiperOrigin-RevId: 444327724
30 second clips at higher resolutions are useful for testing encoder behaviour compared to shorter clips. PiperOrigin-RevId: 444505865
This allows the actual bitmap to be saved, even if output dimensions are different than expected. Otherwise, differing output dimensions would throw an exception, preventing the bitmap from being saved. PiperOrigin-RevId: 444512210
Remove unused saveTestBitmapToCacheDirectory throwOnFailure option. #cleanup PiperOrigin-RevId: 444516857
PiperOrigin-RevId: 444530943
PiperOrigin-RevId: 439866306
We don't currently have enough understanding of the correlation between a specific SSIM score and video quality. Dropping to .90 to make most tests pass. Especially when there's no discernible difference from the videos with .9 and .95 SSIM. PiperOrigin-RevId: 440047551
1/4 is probably unnecessary, as 1/3 of 4k is 720, which should be supported on all practical encoders. PiperOrigin-RevId: 440055144
The new demo GlFrameProcessor is based on BitmapOverlayVideoProcessor from the gl-demo. The demo-only GlFrameProcessor can be deleted once Transformer supports this functionality. PiperOrigin-RevId: 440059735
roboletric -> robolectric PiperOrigin-RevId: 440101421
The DefaultMediaNotificationProvider checks if a command is available before putting the respective action in the notification. PiperOrigin-RevId: 440114422
The MIME type was set to H265 to force transcoding. Now that we have an encoder factory that forces encoding, switching back to H264 ensures the quality test is conducted on more devices (those don't support H265 can be tested now). However, H265 should be part of the quality test after we have proper mechanism to skip test based on device capability. PiperOrigin-RevId: 440132471
PiperOrigin-RevId: 440325693
PiperOrigin-RevId: 440347550
PiperOrigin-RevId: 440378974
The stream with the mp3 track is added because - We only encode to AAC - We only encode when the source track is not AAC Now that we have a way to force encoding, we no longer need the mp3 track. The test asset is kept for later parameterized testing. PiperOrigin-RevId: 440876080
PiperOrigin-RevId: 440906834
PiperOrigin-RevId: 440952335
signalEndOfInputStream makes more sense before isEnded and getPendingInputFrameCount is related to registerInputFrame. PiperOrigin-RevId: 441134418
PiperOrigin-RevId: 441142050
Transformer resolves to null when wrapped, this is a debug line that was not removed. PiperOrigin-RevId: 441200790
PiperOrigin-RevId: 441230941
1. TracksInfo is renamed to Tracks 2. TracksInfo.TrackGroupInfo is renamed to Tracks.Group PiperOrigin-RevId: 441232373
PiperOrigin-RevId: 441250773
…troller-release PiperOrigin-RevId: 441253378
PiperOrigin-RevId: 441424063
What a minimal implementation should include is now explained in the interface javadoc while the method name reflects what the method does. PiperOrigin-RevId: 441432059
With HLS chunkless preparation, audio formats may have no value for channel count. In this case, the DefaultAudioSink will either query the platform for a supported channel count (API 29+) or assume a max channel count based on the encoding spec in order to decide whether the audio format can be played with audio passthrough. Issue: google/ExoPlayer#10204 #minor-release PiperOrigin-RevId: 453644548 (cherry picked from commit 8697338)
Use Collections.synchronizedSet() instead of creating a set from a ConcurrentHashMap because ConcurrentHashMap has a bug in APIs 21/22 that can result in lost updates. PiperOrigin-RevId: 453696565 (cherry picked from commit d506c70)
Some Player implementations have no playlist capability but can still set a MediaItem for playback. Examples are a MediaController connected to a legacy MediaSession, ExoPlayer up to 2.12 or MediaPlayer. To indicate this capability, we need an allowed command in addition to COMMAND_CHANGE_MEDIA_ITEMS that just allows to set a single item that replaces everything that is currently played. #minor-release PiperOrigin-RevId: 453879626 (cherry picked from commit 5333c67)
PiperOrigin-RevId: 453905355 (cherry picked from commit 58f7ac2)
The service handles three different types of `Intents`. Custom command and media command Intents created by the library and media button event Intents from other sources. Media commands from the library as well as from external sources have the action set to `android.intent.action.MEDIA_BUTTON`. If the data URI is set and can be used to identify a session then it is a library Intent. If the Intent is coming from an external KeyEvent, the service implementation is asked which session to use by calling `onGetSession(controllerInfo)` with the controller info being an anonymous legacy controller info. Intents representing a custom command are always coming from the library and hence always have a data URI. Issue: #82 PiperOrigin-RevId: 453932972 (cherry picked from commit 8b592fc)
This change fixes a bug where the player is frozen with HLS chunkless preparation because the audio stream wrappers are not marked as master timestamp sources before preparation. #minor-release PiperOrigin-RevId: 453941815 (cherry picked from commit 9221eeb)
The track selector will select multi-channel formats when those can be spatialized, otherwise the selector will prefer stereo/mono audio tracks. When the device supports audio spatialization (Android 12L+), the DefaultTrackSelector will monitor for changes in the platform Spatializer and trigger a new track selection upon a Spatializer change event. Devices with a `television` UI mode are excluded from audio channel count constraints. #minor-release PiperOrigin-RevId: 453957269 (cherry picked from commit e2f0fd7)
`codecDrainAction` is set to `DRAIN_ACTION_NONE` in 3 places in `MediaCodecRenderer`: * The constructor (so there's no prior state to worry about) * `updateDrmSessionV23()`: Where `mediaCrypto` is reconfigured based on `sourceDrmSession` and `codecDrmSession` is also updated to `sourceDrmSession`. * `resetCodecStateForFlush()`: Where (before this change) the action is unconditionally set back to `DRAIN_ACTION_NONE` and so any required updated implied by `DRAIN_ACTION_FLUSH_AND_UPDATE_DRM_SESSION` is not done. This change ensures that `flushOrReleaseCodec()` handles `DRAIN_ACTION_FLUSH_AND_UPDATE_DRM_SESSION` before calling . This probably also resolves Issue: google/ExoPlayer#10274 #minor-release PiperOrigin-RevId: 454114428 (cherry picked from commit 222faa9)
The default constructor is only allowed to be called on API < 32 and the test should use the defined UNSET constant to be API independent. #minor-release PiperOrigin-RevId: 454568893 (cherry picked from commit e8bcdf4)
PiperOrigin-RevId: 454641746 (cherry picked from commit 970eb44)
#minor-release PiperOrigin-RevId: 454884692 (cherry picked from commit 118d689)
PiperOrigin-RevId: 454943102 (cherry picked from commit 252ae4c)
PiperOrigin-RevId: 454945333 (cherry picked from commit 7f89531)
See https://issuetracker.google.com/208178382 PiperOrigin-RevId: 454949204 (cherry picked from commit 1f380c1)
PiperOrigin-RevId: 454951844 (cherry picked from commit 29bf4c8)
PiperOrigin-RevId: 455094147 (cherry picked from commit ad3348c)
These calls were not implemented so far as they require a mix of initial prepareFrom/playFrom calls and addQueueItem. We can also support clients without queue handling to set single MediaItems. To make the calls consistent and predictable in the session, we need to ensure that none of the play/pause/addQueueItem/ removeQueueItem/prepare/playFromXYZ/prepareFromXYZ are called before the controller is prepared and has media. #minor-release PiperOrigin-RevId: 455110246 (cherry picked from commit b475f1f)
This code path is now completely redundant as the same effect can be achieved by using player.setMediaItem. PiperOrigin-RevId: 455115567 (cherry picked from commit 21d4e85)
#minor-release PiperOrigin-RevId: 455128997 (cherry picked from commit 958105c)
#minor-release PiperOrigin-RevId: 455140203 (cherry picked from commit 646bf56)
PiperOrigin-RevId: 455347182 (cherry picked from commit dc0e5c4)
PiperOrigin-RevId: 455350486 (cherry picked from commit 1c0b4b3)
Fixing lint errors in the string.xml files makes no sense because these are overridden with the next automated string import. Adding a lint-baseline.xml instead for the ui module. See https://issuetracker.google.com/208178382 #minor-release PiperOrigin-RevId: 455354304 (cherry picked from commit 61ab75b)
#minor-release PiperOrigin-RevId: 455372269 (cherry picked from commit 4b4e7cb)
#minor-release PiperOrigin-RevId: 455372568 (cherry picked from commit c7f1b46)
The API 32 SDK has incorrect versioning metadata for Spatializer. It reports the whole class has only been present since API 33 (which is surely impossible given it's present in the API 32 SDK): https://issuetracker.google.com/234009300 The metadata seems to be correct in the API 33 SDK, so this baseline will no longer be needed when we bump to `compileSdkVersion = 33`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.