r1.0.0-alpha03 #52
Merged
r1.0.0-alpha03 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#minor-release PiperOrigin-RevId: 430454251 (cherry picked from commit e8096f0)
Generated by running: ./gradlew wrapper --gradle-version 7.4 --distribution-type all #minor-release PiperOrigin-RevId: 430666317 (cherry picked from commit 92af42b)
Issue: google/ExoPlayer#9996 #minor-release PiperOrigin-RevId: 430773329 (cherry picked from commit 5a304fd)
The command is not needed, because the specified branch is already the default branch on GitHub so will be checked out by clone automatically. PiperOrigin-RevId: 430910549 (cherry picked from commit d342215)
PiperOrigin-RevId: 430911179 (cherry picked from commit 7d38936)
PiperOrigin-RevId: 430946606 (cherry picked from commit 5d0c7b9)
There's no media3 equivalent to the `com.google.android.exoplayer:exoplayer` dependency. PiperOrigin-RevId: 430955037 (cherry picked from commit 8ae74ad)
When a live stream is joined while ads are already playing, the LOADED event is missed and we don't have ad information for those ads in the ad group that are before the ad index at which we joined. This way we can clip the duration when we receive the LOADED event for the last ad in the group. This fixes the problem of the playback controls being hidden when content resumes after the ad group. #minor-release PiperOrigin-RevId: 431269627 (cherry picked from commit 8e8c590)
PiperOrigin-RevId: 431376857 (cherry picked from commit 3e9dfaa)
PiperOrigin-RevId: 431395359 (cherry picked from commit c961ea1)
#minor-release PiperOrigin-RevId: 432154626 (cherry picked from commit 986928a)
This method is no longer needed since we added SubtitleConfiguration#id in 59d98b9. Issue: google/ExoPlayer#10016 #minor-release PiperOrigin-RevId: 432169262 (cherry picked from commit 232f2d8)
#minor-release PiperOrigin-RevId: 432189509 (cherry picked from commit a73a9e9)
The MockPlayer has a single CountDownLatch field and multiple boolean flags that track if a player method was called. Upon calling the methods the latch count. Tests set the latch count to match exactly with the number of expected player interactions then block the test thread until the latch reaches zero and assert the respective method flags are true. This is subject to false positives. If the underneath implementation changes and call more player method, then the test thread will unblock as soon as a certain number of interactions is performed, which may be less than what the test expected originally. However, the test may stil pass if the player thread had enough time to update the expected method flag. This change removes the single CountDownLatch and the boolean flags and instead it adds APIs to query the MockPlayer if a method has been called and await until a method is called. Internally, the MockPlayer has a ConditionVariable per method. PiperOrigin-RevId: 432399077 (cherry picked from commit 45d5121)
PiperOrigin-RevId: 432430345 (cherry picked from commit 8e98187)
This change fixes two bugs where MediaSessionServe shows a notification with the Play icon but tapping it will not start playback: 1. After playback ends: we need to seek to the beginning of the media item. 2. After adding media items to the player but not starting playback: We need to call Player.prepare() too. PiperOrigin-RevId: 432469953 (cherry picked from commit 1023b9d)
This makes the reading period advance early as expected at the end of an ad period. Before this change the reading position of the metadata renderer prevented advancing the period until metadata arrived after the start position of the following period. Only then the reading position of the metadata renderer is updated and beyond the start position of the following period which is a condition to advance the reading period. Because transitioning to the next period is a virtual transition and the SharedMediaPeriod keeps reading from the same underlying sample streams, the metadata renderer can safely be ignored for this check. #minor-release PiperOrigin-RevId: 432646037 (cherry picked from commit c7c7517)
#minor-release PiperOrigin-RevId: 433467068 (cherry picked from commit af6f6bb)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.