Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatroskaExtractor: fixed typo when determining 'rotationDegrees' #461

Merged
merged 2 commits into from
Jun 22, 2023
Merged

MatroskaExtractor: fixed typo when determining 'rotationDegrees' #461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c7c18
Fixed typo when determining 'rotationDegrees'
almiki Jun 13, 2023
d4034bb
Add release notes entry for the fix
rohitjoins Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed typo when determining 'rotationDegrees' 
projectionPosePitch => projectionPoseRoll
  • Loading branch information
@almiki @rohitjoins
almiki authored and rohitjoins committed Jun 20, 2023
commit 77c7c189a6b60444fd3d41acedf6f0fe7efab7f8
8 changes: 4 additions & 4 deletions libraries/extractor/src/main/java/androidx/media3/extractor/mkv/MatroskaExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2293,12 +2293,12 @@ public void initializeOutput(ExtractorOutput output, int trackId) throws ParserE
// The range of projectionPoseRoll is [-180, 180].
if (Float.compare(projectionPoseRoll, 0f) == 0) {
rotationDegrees = 0;
} else if (Float.compare(projectionPosePitch, 90f) == 0) {
} else if (Float.compare(projectionPoseRoll, 90f) == 0) {
rotationDegrees = 90;
} else if (Float.compare(projectionPosePitch, -180f) == 0
|| Float.compare(projectionPosePitch, 180f) == 0) {
} else if (Float.compare(projectionPoseRoll, -180f) == 0
|| Float.compare(projectionPoseRoll, 180f) == 0) {
rotationDegrees = 180;
} else if (Float.compare(projectionPosePitch, -90f) == 0) {
} else if (Float.compare(projectionPoseRoll, -90f) == 0) {
rotationDegrees = 270;
}
}
Expand Down