-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support file schemes in SimpleBitmapLoader #109
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Please sign the license agreement and I'll merge the pull-request. [added] Also, the PR should target the main branch, not the release one. |
Done! |
I've left a comment on the code, I was wondering if you saw it? |
hm, i can't see any comment- |
libraries/session/src/main/java/androidx/media3/session/SimpleBitmapLoader.java
Show resolved
Hide resolved
my bad, the comment should be published now |
I have update the comments in case you didn't get a notice :) |
Thanks! I merged the PR, with some changes and unit tests. It should appear here once we update the main branch |
PiperOrigin-RevId: 464045351 (cherry picked from commit 61e4f92)
Fixes #108