Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file schemes in SimpleBitmapLoader #109

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Conversation

tzugen
Copy link

@tzugen tzugen commented Jul 6, 2022

Fixes #108

@google-cla
Copy link

google-cla bot commented Jul 6, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@christosts christosts self-assigned this Jul 6, 2022
@christosts
Copy link
Contributor

christosts commented Jul 6, 2022

Please sign the license agreement and I'll merge the pull-request.

[added] Also, the PR should target the main branch, not the release one.

@tzugen tzugen changed the base branch from release to main July 8, 2022 08:10
@tzugen
Copy link
Author

tzugen commented Jul 8, 2022

Done!

@christosts
Copy link
Contributor

I've left a comment on the code, I was wondering if you saw it?

@tzugen
Copy link
Author

tzugen commented Jul 22, 2022

hm, i can't see any comment-

@christosts
Copy link
Contributor

my bad, the comment should be published now

@tzugen tzugen requested a review from christosts July 26, 2022 18:12
@tzugen
Copy link
Author

tzugen commented Jul 30, 2022

I have update the comments in case you didn't get a notice :)

@christosts
Copy link
Contributor

Thanks! I merged the PR, with some changes and unit tests. It should appear here once we update the main branch

@tonihei tonihei merged commit 61e4f92 into androidx:main Aug 8, 2022
microkatz pushed a commit that referenced this pull request Nov 22, 2022
PiperOrigin-RevId: 464045351
(cherry picked from commit 61e4f92)
@androidx androidx locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support File Uris in SimpleBitmapLoader
3 participants