Skip to content

Commit

Permalink
Fix parameter name mismatch in MappingTrackSelector.selectTracks
Browse files Browse the repository at this point in the history
It's not clear to me why presubmit didn't catch this, I briefly
investigated but couldn't work it out - so I'm just going to fix
it and move on.

#minor-release

PiperOrigin-RevId: 487497827
(cherry picked from commit 4fcc019)
  • Loading branch information
icbaker authored and microkatz committed Nov 10, 2022
1 parent 824cbf4 commit 2826a55
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2392,7 +2392,7 @@ private void setParametersInternal(Parameters parameters) {
selectTracks(
MappedTrackInfo mappedTrackInfo,
@Capabilities int[][][] rendererFormatSupports,
@AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupports,
@AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupport,
MediaPeriodId mediaPeriodId,
Timeline timeline)
throws ExoPlaybackException {
Expand All @@ -2412,7 +2412,7 @@ private void setParametersInternal(Parameters parameters) {
selectAllTracks(
mappedTrackInfo,
rendererFormatSupports,
rendererMixedMimeTypeAdaptationSupports,
rendererMixedMimeTypeAdaptationSupport,
parameters);

applyTrackSelectionOverrides(mappedTrackInfo, parameters, definitions);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ public final TrackSelectorResult selectTracks(
* Given mapped track information, returns a track selection and configuration for each renderer.
*
* @param mappedTrackInfo Mapped track information.
* @param rendererFormatSupports The {@link Capabilities} for ach mapped track, indexed by
* @param rendererFormatSupports The {@link Capabilities} for each mapped track, indexed by
* renderer, track group and track (in that order).
* @param rendererMixedMimeTypeAdaptationSupport The {@link AdaptiveSupport} for mixed MIME type
* adaptation for the renderer.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ private static final class FakeMappingTrackSelector extends MappingTrackSelector
protected Pair<RendererConfiguration[], ExoTrackSelection[]> selectTracks(
MappedTrackInfo mappedTrackInfo,
@Capabilities int[][][] rendererFormatSupports,
@AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupports,
@AdaptiveSupport int[] rendererMixedMimeTypeAdaptationSupport,
MediaPeriodId mediaPeriodId,
Timeline timeline) {
int rendererCount = mappedTrackInfo.getRendererCount();
Expand Down

0 comments on commit 2826a55

Please sign in to comment.