Usability improvements for hello-vulkan sample #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant functions and calls Report validation layer messages to logcat Auto-disable validation layers when not found Feature support checks to avoid validation failures Rename some function and variables to fix linter and name shadowing warnings Extra logging to help with debugging
kocdemir
changed the title
|
@DanAlbert I've separated the previous PR into 2 commits in this one to ease the review. Thanks |
|
It's probably going to be a while before I have the time to review this. I can't review and merge half of a PR. If the 7 things this PR was doing were 7 PRs, I'd probably be able to deal with one or two a day. If it's one PR it's going to have to wait until I have time to review the whole thing, and I don't even know Vulkan. It won't happen any time soon. |
|
Sure, this is not urgent and not changing the behavior much. Original owner of the sample, @GOOG-sergiu, can help with reviewing Vulkan related changes. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move class functions into a cpp file in a separate commit to improve readability for the project.
Remove redundant functions and calls
Report validation layer messages to logcat
Auto-disable validation layers when not found
Feature support checks to avoid validation failures
Rename some function and variables to fix linter and name shadowing warnings
Extra logging to help with debugging