Use setup-android to make sdkmanager available. #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the action's docs I don't think sdkmanager is actually unavailable, just obnoxious to find (seems the SDK moved that component to `cmdline-tools/$VERSION/bin`, and I've got no idea how to guess the version). We could make broader use of this by moving the guts of `setup_env.sh` into build.yml, but to do that we'd have to remove the auto-detection of which NDK versions we need (though that's a bug anyway, AGP's supposed to be installing those for us). For now, just unbreak CI and we can deal with that later if it's ever worth doing. Using setup-android also requires that we update to a newer version of Java in setup-java.
enh-google
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the action's docs I don't think sdkmanager is actually unavailable, just obnoxious to find (seems the SDK moved that component to
cmdline-tools/$VERSION/bin, and I've got no idea how to guess the version).We could make broader use of this by moving the guts of
setup_env.shinto build.yml, but to do that we'd have to remove the auto-detection of which NDK versions we need (though that's a bug anyway, AGP's supposed to be installing those for us). For now, just unbreak CI and we can deal with that later if it's ever worth doing.