Replacement of tv-foudation from the dependencies of the TV app #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dation is going to be deprecated
chikoski
commented
Jul 9, 2024
Jetcaster/tv/src/main/java/com/example/jetcaster/tv/ui/JetcasterApp.kt
Outdated
Show resolved
Hide resolved
Jetcaster/gradle/libs.versions.toml
Outdated
There was a problem hiding this comment.
All samples use the same main libs.version.toml file. It is duplicated every time we do a release cycle. So updating one sample's dependencies will not work, as the file will simply be overwritten next time the samples are updated.
Do we really need this update now, or can we wait for the stable 1.7.0 release?
There was a problem hiding this comment.
Thanks for the suggestion. It sounds we should wait the stable 1.7.0 release. I will change the state of the PR to draft and come back when 1.7.0 becomes stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replace the tv-foundation with Compose Foundation 1.7.0-beta04 as tv-foundation is going to be deprecated in the next release.
In addition to that, this pull request fixes a crashing bug that happens on the discovery screen of the TV app, as a part of the replacement.