Experimenting with safe versions of Shared element modifiers. #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Modifier.safeSharedElement, Modifier.safeSharedBounds, Modifier.safeSkipToLookaheadSize, Modifier.safeRenderInSharedTransitionScope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes your composables may be created from places that don't have a AnimatedContentScope or SharedTransitionScope - for instance if you are opening up your app from a notifcation. Instead of throwing an IllegalArgumentException in these cases, it'd be best if the shared element modifiers, just didn't do anything if the scopes are not present.
This pull request creates new modifiers that wrap the shared element APIs, to skip their operation if the scopes are null. Modifiers such as:
Modifier.safeSharedElement(),Modifier.safeSharedBounds(),Modifier.safeSkipToLookaheadSize(),Modifier.safeRenderInSharedTransitionScope().Please note: This is in no way a complete solution at present, this is an experiment and subject to change. Please do leave feedback if you'd like to see changes to shared element APIs based on this use case.