[Reply] Use NavigationSuite for nav UI components #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add material3-adaptive-navigation-suite to top level catalog and copy over to Reply.
Uses NavigationSuiteScaffoldLayout to create a navigation wrapper UI.
alexvanyo
approved these changes
May 29, 2024
Comment on lines
+115
to
+118
| // Avoid opening the modal drawer when there is a permanent drawer or a bottom nav bar, | ||
| // but always allow closing an open drawer. | ||
| val gesturesEnabled = | ||
| drawerState.isOpen || navLayoutType == NavigationSuiteType.NavigationRail |
There was a problem hiding this comment.
This logic does makes sense for consistency, where the drawer will remain open if it was open, but maybe an alternative would be to just hide it immediately if the navigation layout type isn't a navigation rail? Not sure which way would be better.
There was a problem hiding this comment.
I tried something like that, and it looked fine when changing to a layout that isn't a rail. But when changing back to the rail the drawer opens again, and that's a bit jarring.
We can work around that with a LaunchedEffect that calls drawerState.snapTo(Closed), but that feels more imperative than declarative.
bentrengrove
reviewed
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.