[JetNews] Add preview to glance widget #1402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkoren
reviewed
May 20, 2024
| ) | ||
| Spacer(modifier = GlanceModifier.width(8.dp)) | ||
| Image( | ||
| contentDescription = context.getString(R.string.app_name), |
There was a problem hiding this comment.
Should this be stringResource instead?
There was a problem hiding this comment.
Not sure. I didn't change any of the content, just extracted the composable so it's easy to preview.
I'll take a look and raise a different PR if needed.
Good catch!
There was a problem hiding this comment.
Looks like stringResource hasn't been ported to glance yet
https://issuetracker.google.com/issues/216663009
|
This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds previews to the JetNews Glance widget
Fixes #1401 🦕