Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetcaster] fix d-pad focus issues of TV app #1396

Merged
merged 6 commits into from
May 9, 2024
Merged

[Jetcaster] fix d-pad focus issues of TV app #1396

merged 6 commits into from
May 9, 2024

Conversation

chikoski
Copy link
Contributor

@chikoski chikoski commented May 8, 2024

This pull request fixes the following focus issues:

  • The item for the current screen does not got focused when users move the d-pad focus to the NavigationDrawer
  • The app crashes when users are moving d-pad focus to the podcast list from the tab item if the podcast list for the previous category is longer than current category's one
  • D-pad focus moves to the different component according to the selected episode in the queue on the player screen

@chikoski chikoski requested a review from arriolac May 8, 2024 10:08
@chikoski chikoski requested a review from a team as a code owner May 8, 2024 10:09
@chikoski chikoski merged commit 985b4bb into android:main May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arriolac arriolac arriolac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chikoski @arriolac