Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider waiving attributionsrc for triggers #347

Closed
maudnals opened this issue Feb 25, 2022 · 2 comments
Closed

Consider waiving attributionsrc for triggers #347

maudnals opened this issue Feb 25, 2022 · 2 comments
Labels
developer-input Question/feedback raised by a developer and posted here on their behalf for public discussion

Comments

@maudnals
Copy link
Contributor

maudnals commented Feb 25, 2022

Question/Feedback from developer:

Requiring attributionsrc on conversion registrations is problematic for existing image tags.
It may make it difficult for existing tags to test the API.
Based on this TODO ("Finalize whether the attributionsrc attribute should be optional to support legacy HTML tags for triggers"), is it possible to waive this requirement for conversion registration?

@maudnals
Copy link
Contributor Author

@johnivdel

@maudnals maudnals changed the title Consider waiving attributionsrc for triggers? Consider waiving attributionsrc for triggers Feb 25, 2022
@maudnals maudnals added the developer-input Question/feedback raised by a developer and posted here on their behalf for public discussion label Feb 25, 2022
@johnivdel
Copy link
Collaborator

Some of the implications here:

This would dis-align the permissions model on the source and trigger side. With attributionsrc, we have a tag-level opt-in to the API. Processing headers without the attribute would be similar to the previous version, all subresources on the page would be able to register triggers.

On the source side, this permissive model would make it easy to abuse limits on unattributed sources (such as the 100 reporting origin limit). On the trigger side, we don't have any rate-limits which operate on unattributed triggers, so there is less concern for DOS style attacks.

We do have limits on attributed triggers, but this is already contingent on an action from a publisher site, and these limits include reporting origin in the scope.

Based on this, I think it would be reasonable to remove the requirement to support pre-existing conversion tags.

johnivdel added a commit that referenced this issue Mar 14, 2022
Removes the attributionsrc requirement for trigger registration, fixing #347
johnivdel added a commit that referenced this issue Mar 15, 2022
* Resolve todo on supporting legacy conversion pings

Removes the attributionsrc requirement for trigger registration, fixing #347

* Update EVENT.md

* Update EVENT.md

Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>

Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 16, 2022
This CL adds processing for non-attributionsrc trigger registration as
proposed in:
WICG/attribution-reporting-api#347
WICG/attribution-reporting-api#360

This change parses and plumbs the data to the browser process.
Browser process registration is implemented in crrev.com/c/3518045.

Bug: 1294286
Change-Id: Id6c2c24ec936bcb47d6add6292f49b9aba13aa59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3518053
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981615}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
This CL adds processing for non-attributionsrc trigger registration as
proposed in:
WICG/attribution-reporting-api#347
WICG/attribution-reporting-api#360

This change parses and plumbs the data to the browser process.
Browser process registration is implemented in crrev.com/c/3518045.

Bug: 1294286
Change-Id: Id6c2c24ec936bcb47d6add6292f49b9aba13aa59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3518053
Reviewed-by: John Delaney <johnidel@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981615}
NOKEYCHECK=True
GitOrigin-RevId: 648503f0ee23669946ebcd7115c957ab05bc65ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-input Question/feedback raised by a developer and posted here on their behalf for public discussion
Projects
None yet
Development

No branches or pull requests

3 participants