Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Wellspring back into development branch #2560

Merged
merged 22 commits into from
Jan 10, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7559b86
Restore release date for 4.9.1 RC1 in release notes.
WardF Nov 17, 2022
19b8ae4
Added target release date for RC2.
WardF Nov 17, 2022
087d3b6
Supported headers for hdf4 are not installed in actions, and there do…
WardF Nov 18, 2022
74b4aae
Update release date.
WardF Nov 18, 2022
573e892
DAP4 is back on for cmake-based builds.
WardF Nov 21, 2022
a03bb5e
Fix infinite loop in file inferencing
DennisHeimbigner Dec 18, 2022
9226b52
Add an old static file.
WardF Dec 19, 2022
dd99d60
Added another old static html page in preparation for updating.
WardF Dec 19, 2022
c228426
Fix a logic error re: DAP4 tests, when DAP4 is specified, but hdf5/ne…
WardF Dec 19, 2022
a71d77b
Merge branch 'restore_old_doc.wif' of https://github.com/WardF/netcdf…
WardF Dec 20, 2022
435f16b
Merge branch 'loop.dmh' of https://github.com/DennisHeimbigner/netcdf…
WardF Jan 4, 2023
9ea2739
Added S3 status to libnetcdf.settings, turned byterange on by default.
WardF Jan 9, 2023
ecd48ae
Cleaning up NCZARR_S3 summary, turning on byterange by default.
WardF Jan 9, 2023
19a1f9e
Add libcurl-dev to cygwin github actions
WardF Jan 9, 2023
e02f678
Correct libcurl development package.
WardF Jan 9, 2023
bd03412
Add libiconv-devel to cygwin CI
WardF Jan 9, 2023
394cf64
Correct version string change that should not have ended up in this b…
WardF Jan 9, 2023
3e35a10
Correct logic for running DAP4 tests when HDF5 is not enabled.
WardF Jan 10, 2023
4c27c59
Update whitespace.
WardF Jan 10, 2023
341a43b
Correct lingering merge issue.
WardF Jan 10, 2023
0006545
Merging https://github.com/Unidata/netcdf-c/pull/2583 manually into t…
WardF Jan 10, 2023
b67583f
Fix a doxygen warning-treated-as-error
WardF Jan 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merging #2583 manually into the v4.9.1 wellspring branch.
  • Loading branch information
WardF committed Jan 10, 2023
commit 00065451fc002cc5e1d0e71014af8b3d7c4232c8
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -2065,12 +2065,12 @@ AX_SET_META([NC_HAS_SZIP],[$enable_hdf5_szip],[yes])
AX_SET_META([NC_HAS_ZSTD],[$have_zstd],[yes])
AX_SET_META([NC_HAS_BLOSC],[$have_blosc],[yes])
AX_SET_META([NC_HAS_BZ2],[$have_bz2],[yes])

# This is the version of the dispatch table. If the dispatch table is
# changed, this should be incremented, so that user-defined format
# applications like PIO can determine whether they have an appropriate
# dispatch table to submit. If this is changed, make sure the value in
# CMakeLists.txt also changes to match.

AC_SUBST([NC_DISPATCH_VERSION], [5])
AC_DEFINE_UNQUOTED([NC_DISPATCH_VERSION], [${NC_DISPATCH_VERSION}], [Dispatch table version.])

Expand Down
26 changes: 26 additions & 0 deletions docs/dispatch.md
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,32 @@ The code in *hdf4var.c* does an *nc_get_vara()* on the HDF4 SD
dataset. This is all that is needed for all the nc_get_* functions to
work.

# Appendix A. Changing NC_DISPATCH_VERSION

When new entries are added to the *struct NC_Dispatch* type
-- located in *include/netcdf_dispatch.h.in -- it is necessary to
do two things.
1. Bump the NC_DISPATCH_VERSION number
2. Modify the existing dispatch tables to include the new entries.
It if often the case that the new entries do not mean anything for
a given dispatch table. In that case, the new entries may be set to
some variant of *NC_RO_XXX* or *NC_NOTNC4_XXX* *NC_NOTNC3_XXX*.

Modifying the dispatch version requires two steps:
1. Modify the version number in *netcdf-c/configure.ac*, and
2. Modify the version number in *netcdf-c/CMakeLists.txt*.

The two should agree in value.

### NC_DISPATCH_VERSION Incompatibility

When dynamically adding a dispatch table
-- in nc_def_user_format (see libdispatch/dfile.c) --
the version of the new table is compared with that of the built-in
NC_DISPATCH_VERSION; if they differ, then an error is returned from
that function.


# Point of Contact {#dispatch_poc}

*Author*: Dennis Heimbigner<br>
Expand Down