Correct VkAccelerationStructureGeometryTrianglesDataKHR::maxVertex value #1097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VkAccelerationStructureGeometryTrianglesDataKHR::maxVertex is the maximum vertex index in the VkAccelerationStructureGeometryTrianglesDataKHR::vertexData buffer i.e. the spec states "maxVertex is the number of vertices in vertexData minus one".
Currently the maxVertex value in the ray_queries and ray_tracing_extended is being set to the number of vertices, so this patch fixes them. It's not caused any problems so far as both examples use an index buffer - but it's better to be technically correct!
Tested on:
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: