Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Image Compression Control sample tutorial #1096

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

JoseEmilio-ARM
Copy link
Collaborator

Description

Documentation change only

When querying for image compression support, VK_IMAGE_COMPRESSION_FIXED_RATE_DEFAULT_EXT should be used, as shown in the extension proposal, otherwise the returned imageCompressionFixedRateFlags might be 0.

This is correct in the framework/sample, but was copied incorrectly in the tutorial.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • [n/a] I did a full batch run using the batch command line argument to make sure all samples still work properly

When querying for image compression support, `VK_IMAGE_COMPRESSION_FIXED_RATE_DEFAULT_EXT` should be used, as shown in the [extension proposal](https://docs.vulkan.org/features/latest/features/proposals/VK_EXT_image_compression_control.html#_examples)
@SaschaWillems SaschaWillems self-requested a review July 11, 2024 14:52
@marty-johnson59
Copy link
Contributor

Low risk change - merging on 2 approvals

@marty-johnson59 marty-johnson59 merged commit 34e2ec1 into main Jul 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants