-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sample for ray tracing position fetch #1070
Add new sample for ray tracing position fetch #1070
Conversation
This reverts commit 7504395.
Work-in-progress
Required to access buffers in the ray tracing position fetch sample
Get buffer device addresses from buffer class
…ructure Existing function variant can't be used directly with the glTF loader
Was hardcoded as UINT32, which would fail for models using different types
|
||
// Sample sepcific feature | ||
auto &requested_ray_tracing_position_fetch_features = gpu.request_extension_features<VkPhysicalDeviceRayTracingPositionFetchFeaturesKHR>(VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_RAY_TRACING_POSITION_FETCH_FEATURES_KHR); | ||
requested_ray_tracing_position_fetch_features.rayTracingPositionFetch = VK_TRUE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be adjusted when #1013 gets merged.
samples/extensions/ray_tracing_position_fetch/ray_tracing_position_fetch.cpp
Outdated
Show resolved
Hide resolved
samples/extensions/ray_tracing_position_fetch/ray_tracing_position_fetch.h
Show resolved
Hide resolved
samples/extensions/ray_tracing_position_fetch/ray_tracing_position_fetch.h
Show resolved
Hide resolved
Signed-off-by: Sascha Willems <webmaster@saschawillems.de>
…geometry. Signed-off-by: Sascha Willems <webmaster@saschawillems.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build ok for me and correctly reports not supported. I can't test any more than that sadly.
I can test on AMD + Intel GPU this week. |
Description
This PR adds a new sample for the VK_KHR_ray_tracing_position_fetch extension. It comes with a small tutorial, and shaders both for GLSL and HLSL.
Developed and tested on an nvidia RTX 4070 and Windows 11.
Important note: Requires new assets from this PR: KhronosGroup/Vulkan-Samples-Assets#26
Fixes #1004
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: