Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unused tests. These tests either do not currently work, do not get run in CI or test capabilities that the project does not support. Removing these tests simplifies the project further.
system_tests
Around from the early days. Are not super useful as they do not test actual framework usage. Are not run in CI and are not actively updated (other than compile errors). I believe these add no substantial value and we should encourage using Catch2 where necessary to test actual code.
generate project
This is used in the CI but we do not actively test Vulkan Samples as a dependency to another project. We also do not encourage users of the project to clone the framework.
generate sample
This test no longer works. It is also not used in the CI and currently new sample builds take up a lot of time! #458 might be able to fix this
Fixes #959
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: