-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requested_stats_count value cause no performance counters working #1055
Fix requested_stats_count value cause no performance counters working #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Would you be able to also rename requested_stats_count
to stat_data_count
?
Of course. I will handle this next Monday :)
程沛楠
TECH-图形引擎组-Rendering Engine | 图形引擎开发工程师-Rendering Engine Programmer
[image]
BOOMING TECH | 不鸣科技
www.boomingtech.com<http://www.boomingtech.com/>
From: ***@***.***>
Date: Thu, May 23, 2024, 23:26
Subject: Re: [KhronosGroup/Vulkan-Samples] Fix requested_stats_count value cause no performance counters working (PR #1055)
To: ***@***.***>
Cc: ***@***.***>, ***@***.***>
@JoseEmilio-ARM approved this pull request.
Thank you very much! Would you be able to also rename requested_stats_count to stat_data_count?
—
Reply to this email directly, view it on GitHub<#1055 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKM3VCYWNMCWTMQFXM34XMLZDYDBXAVCNFSM6AAAAABIE2WC6GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZUGMZDQMRVGI>.
You are receiving this because you authored the thread.[image: https://github.com/notifications/beacon/AKM3VC2N5G6FOSMZ3GZ6S53ZDYDBXA5CNFSM6AAAAABIE2WC6GWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT3UO6LY.gif]Message ID: ***@***.***>
保密提示:本邮件及其任何附件具有保密性质,并可能受其他保护不允许被披露给第三方。如阁下误收到本邮件,敬请立即以回复电子邮件的方式通知发信人,并将本邮件及其任何附件从阁下系统中予以删除。如阁下并非本邮件写明之收件人,敬请切勿使用、复制、披露本邮件或其任何内容,亦请切勿依本邮件或其任何内容而采取任何行动。多谢合作!
CONFIDENTIALITY CAUTION: This email or the attachments therein are solely intended for the recipient and may contain confidential and/or privileged information. If it has reached you by mistake, please do not read, copy, save, forward or disseminate it to anyone else. We would appreciate it if you could delete it from your system and inform us by returning this email. Thank you.
|
I have already renamed |
Approved from a code standpoint. Can't test on android at the moment! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Description
I found out that all HWCPipe counters not working when I downloaded the newest vulkan samples, and then i found out why and fixed it.
Fixes #1053
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: