Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screenshot path for dynamic primitive clipping sample #1029

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

SaschaWillems
Copy link
Collaborator

Fix Antora build

Description

Fixes the screenshot path for the dynamic primitive clipping sample which would result in an error when building the Antora site and a missing screenshot on the documentation site.

Note: This is a pure documentation fix.

Fixes #1028

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Fix Antora build
Fixes #1028
@SaschaWillems SaschaWillems added the documentation Improvements or additions to documentation label Apr 16, 2024
Copy link
Contributor

@asuessenbach asuessenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the same change be needed in README.adoc, line 26?

@tomadamatkinson tomadamatkinson merged commit 3e971fb into main Apr 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing screenshot is causing error in Antora site build
5 participants