Don't implicitly enable dedicated memory allocation #1023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For whatever reason the framework implicitly enables dedicated memory allocation if the extension is present. It's the only memory related feature that we implicitly enabled, unlike all other features that are only enabled if the required extension is actually requested by the sample. see https://github.com/KhronosGroup/Vulkan-Samples/blob/main/framework/core/allocated.h#L144
This seems to have been introduced recently and broke the profiles sample.
This PR changes this behavior and enables dedicated memory allocations only if the extension is actually requested (which isn't the case for any samples btw). In general I'm not a fan of implicitly enabled things for samples that show how to use an explicit api like Vulkan.
This fixes the profiles sample.
Fixes #1008
Did a batch run on Windows 11 with an RTX 4070 and saw no errors. Sadly batch run failed at some point as some samples on main are simply broken.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: