Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't implicitly enable dedicated memory allocation #1023

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

SaschaWillems
Copy link
Collaborator

Description

For whatever reason the framework implicitly enables dedicated memory allocation if the extension is present. It's the only memory related feature that we implicitly enabled, unlike all other features that are only enabled if the required extension is actually requested by the sample. see https://github.com/KhronosGroup/Vulkan-Samples/blob/main/framework/core/allocated.h#L144

This seems to have been introduced recently and broke the profiles sample.

This PR changes this behavior and enables dedicated memory allocations only if the extension is actually requested (which isn't the case for any samples btw). In general I'm not a fan of implicitly enabled things for samples that show how to use an explicit api like Vulkan.

This fixes the profiles sample.

Fixes #1008

Did a batch run on Windows 11 with an RTX 4070 and saw no errors. Sadly batch run failed at some point as some samples on main are simply broken.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@SaschaWillems SaschaWillems added the framework This is relevant to the framework label Apr 16, 2024
@tomadamatkinson tomadamatkinson merged commit 59a236e into main Apr 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This is relevant to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiles sample no longer working
4 participants