Change build configuration from CPP14 to CPP17 #1017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently more CPP17 code was added to the code-base, although our minimum requirements
is CPP14. This PR bumps the supported cpp standard to cpp17.
The impact of this change is small, as vulkan samples were already compiled using the CPP17 standard
This only makes it more prominent by updating the documentation and build configuration.
This issue was detected when working on #994. This PR splits the framework into multiple library and
the newly introduced library was compiled using CPP14.
I left the minimum required visual studio version to 17 as currently it isn't a known problem.
Fixes #1016
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: