Fix #1006: Disable Objective-C in clang-format #1012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1006
Regression introduced by iOS support. The clang format configuration file doesn't contain a section for
objective-c files and using
script/clang-format.py
would fail because it cannot exclude objective-cfiles based on extension alone.
Both CPP and ObjectiveC uses the same extension for their header files (
.h
)This has been fixed by adding a configuration section to
.clang-format
to ignore Objective-Cfiles.
Eventually we should improve the configuration. for example use LLVM style for Objective-C
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: