Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add report header #777

Merged
merged 31 commits into from
Jul 26, 2024
Merged

Feat: Add report header #777

merged 31 commits into from
Jul 26, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jul 24, 2024

Description

Add report header to CLI dashboard landing pages, downloaded report from CLI and the extension.

Relevant Technical Choices

Testing Instructions

  • Header should be available in the report downloaded from the extension.
  • Header should be available in the report downloaded from the CLI
  • It should also be available in the CLI dashboard when a single URL is audited.
  • It should also be available in the CLI dashboard aggregated page and the internal insights page when a sitemap URL is audited.
  • The header should include the correct URL, date and time.
  • The title of the header (on the right) should be different for the extension and the CLI.

Additional Information:

Screenshot/Screencast

image

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #739

@mohdsayed mohdsayed self-assigned this Jul 24, 2024
@mohdsayed mohdsayed marked this pull request as ready for review July 24, 2024 13:28
@mohdsayed mohdsayed added this to the v1.0.0 milestone Jul 24, 2024
@mohdsayed mohdsayed requested a review from amovar18 July 26, 2024 11:47
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 479911d into develop Jul 26, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/add-report-header branch July 26, 2024 12:18
@mohdsayed mohdsayed mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants