Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Change cookie database URL #415

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

milindmore22
Copy link
Collaborator

Description

This PR changes the open cookie database URL, As discussed on call, we will be using our forked repo for the global cookie db. This will eliminate dependency on third-party repo.

Relevant Technical Choices

The raw GitHub URL that points to CSV will be changed.

Testing Instructions

run the npm run cookie-db:update command

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Copy link

google-cla bot commented Jan 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@milindmore22 milindmore22 changed the base branch from main to develop January 15, 2024 11:37
@mohdsayed mohdsayed merged commit 64088b0 into develop Jan 15, 2024
4 checks passed
@mohdsayed mohdsayed deleted the update/change-cookie-db-source branch January 15, 2024 18:38
mayan-000 pushed a commit that referenced this pull request Jan 18, 2024
Co-authored-by: sayedtaqui <sayedwp@gmail.com>
fellyph pushed a commit that referenced this pull request Jan 27, 2024
Co-authored-by: sayedtaqui <sayedwp@gmail.com>
@mohdsayed mohdsayed mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants