Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(trace-processor): correct overlapping tasks #15921

Merged
merged 3 commits into from
Apr 4, 2024
Merged

core(trace-processor): correct overlapping tasks #15921

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42d7155
core(trace-processor): correct overlapping tasks
adamraine Apr 4, 2024
00f895f
ope
adamraine Apr 4, 2024
ec4da48
tests
adamraine Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ope
  • Loading branch information
@adamraine
adamraine committed Apr 4, 2024
commit 00f895f6b586090a9a8e2784ee1c0f65939bfe03
3 changes: 2 additions & 1 deletion core/lib/tracehouse/trace-processor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,8 @@ class TraceProcessor {

// Temporary fix for a Chrome bug where some RunTask events can be overlapping.
// We correct that here be ensuring each RunTask ends at least 1 microsecond before the next
// https://crbug.com/40825479
// https://github.com/GoogleChrome/lighthouse/issues/15896
// https://issues.chromium.org/issues/329678173
if (prevToplevel && start < prevToplevel.end) {
prevToplevel.end = start - 0.001;
}
Expand Down
Loading