Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade lighthouse-logger to 2.0.1 #15282

Merged
merged 3 commits into from
Jul 20, 2023
Merged

deps: upgrade lighthouse-logger to 2.0.1 #15282

merged 3 commits into from
Jul 20, 2023

Conversation

adamraine
Copy link
Member

No need for the extra type declaration file now!

@adamraine adamraine requested a review from a team as a code owner July 17, 2023 23:32
@adamraine adamraine requested review from connorjclark and removed request for a team July 17, 2023 23:32
yarn.lock Outdated
version "1.4.1"
resolved "https://registry.yarnpkg.com/lighthouse-logger/-/lighthouse-logger-1.4.1.tgz#a076d7be80cbac16b9fdcd930379b03fff514699"
integrity sha512-VDZF31xGrLS1Zyf79/Xs6J9I08EVgJyz085MAt0G3Sh6nARFSUaM+IkuEZE9xZrLpTtzH1Qt9UzH/7kt9LnhZQ==
dependencies:
debug "^2.6.9"
marky "^1.2.2"

lighthouse-logger@^2.0.0:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like LH and chrome-launcher will be using different version of this package. In practice this should be fine since the important global state is stored in marky.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thinking through every possible permutation of people doing weird things with their deps, is there any chance this could cause a problem like we had with 10.3.0 or whatever? Would going through the pain of bumping chrome-launcher be worth it to avoid any trouble?

Copy link
Member Author

@adamraine adamraine Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So chrome launcher compiles to CJS, which means we would need to make a breaking release to chrome launcher or reintroduce CJS support to the logger.

Edit: I think it's worth the trouble, I just don't know which option is better
Edit2: Lol forgot we already did this GoogleChrome/chrome-launcher#302 (but not rls)

@adamraine adamraine changed the title deps: upgrade lighthouse-logger to 2.0.0 deps: upgrade lighthouse-logger to 2.0.1 Jul 18, 2023
@adamraine adamraine merged commit 7587605 into main Jul 20, 2023
24 checks passed
@adamraine adamraine deleted the log-up-2 branch July 20, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants