-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: add cjs path for logger #15084
Conversation
Does this mean there will be two versions used in a typical LH run? |
That may have already been the case w/ chrome launcher requesting version 1.0.0 and lighthouse requesting version 1.3.0 (soon to be 1.4.1) |
Sure, but that's always the case. chrome-launcher is requesting It would be good to have a path out of this situation (e.g. update chrome-launcher) for after this fix lands. |
All the state is stored in |
Today it is! We control all the pieces here, so there's no reason we can't make it simple again now that the shipping version is working. |
We need to do a patch release to restore cjs since the update today broke some folks downstream.
I packaged this logger and verified that chrome launcher passed all it's tests with it.