tests(eslint): add export rule #13282
Conversation
| @@ -12,11 +12,11 @@ import {getFilmstripFrames, getScreenDimensions, getFullPageScreenshot} from './ | |||
|
|
|||
| const ANIMATION_FRAME_DURATION_MS = 500; | |||
|
|
|||
| export const Separator: FunctionComponent = () => { | |||
| const Separator: FunctionComponent = () => { | |||
There was a problem hiding this comment.
ah, I forgot about flow report stuff. This is a big change for this code. @adamraine what are your thoughts on export style for component files?
We could always exclude tsx files if it's generally considered more idiomatic this way
There was a problem hiding this comment.
It's fine, I'll probably get used to it
report/renderer/util.js
Outdated
| /** | ||
| * Report-renderer-specific strings. | ||
| */ | ||
| const UIStrings = { |
There was a problem hiding this comment.
This is more in line with every other use of UIStrings, but to me this isn't worth breaking blame.
|
👍 to the rules. i find it easier to navigate this way. |
|
can't work out this TS error. @brendankenny thoughts? https://gist.github.com/connorjclark/20a7d2df46fbc440da83fbbc7f84d795 |
|
one of the tsc projects is seeing into |
Adds lint rules enforcing 1) no statements after an export and 2) at most one export statement in a file