-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in support of Issue #175 #181
Conversation
Minor update to |
That works, just wanted to finish up the code and get it uploaded before I
forgot..
…On Tue, Nov 7, 2023 at 8:45 PM Tatu Saloranta ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pom.xml
<#181 (comment)>:
> <!-- Woodstox 5.0 is 1.6+ -->
- <javac.src.version>1.6</javac.src.version>
- <javac.target.version>1.6</javac.target.version>
+ <jdk.version>1.8</jdk.version>
Will then need to go in after #134
<#134> is done (which itself
is after 6.6.0 release). Probably not a problem as MSV-core change may take
a while.
—
Reply to this email directly, view it on GitHub
<#181 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BA7WS6W6JSGTXLZU65KTOBLYDLP2NAVCNFSM6AAAAAA7B7XAZCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJZGE3DQNZVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@Orbisman Is this still active? While the referenced issue in MSV was closed, there doesn't appear to be a new build available so I don't think this can be completed... but maybe at least could trim down changes to |
Sorry for the delayed response, yes, remove the POM changes that was in error... |
Going to resubmit pull request without pom |
Pull request for Issue #175..
Dependent on Issue #7 on the MSV project being approved and code accepted.
New JUnit w/supporting files included.
Note: pom file change should not be included, my mistake.