Changes in support of Issue #175 #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor update to |
cowtowncoder
reviewed
Nov 8, 2023
|
That works, just wanted to finish up the code and get it uploaded before I
forgot..
…On Tue, Nov 7, 2023 at 8:45 PM Tatu Saloranta ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pom.xml
<#181 (comment)>:
> <!-- Woodstox 5.0 is 1.6+ -->
- <javac.src.version>1.6</javac.src.version>
- <javac.target.version>1.6</javac.target.version>
+ <jdk.version>1.8</jdk.version>
Will then need to go in after #134
<#134> is done (which itself
is after 6.6.0 release). Probably not a problem as MSV-core change may take
a while.
—
Reply to this email directly, view it on GitHub
<#181 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BA7WS6W6JSGTXLZU65KTOBLYDLP2NAVCNFSM6AAAAAA7B7XAZCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJZGE3DQNZVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@Orbisman Is this still active? While the referenced issue in MSV was closed, there doesn't appear to be a new build available so I don't think this can be completed... but maybe at least could trim down changes to |
|
Sorry for the delayed response, yes, remove the POM changes that was in error... |
|
Going to resubmit pull request without pom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for Issue #175..
Dependent on Issue #7 on the MSV project being approved and code accepted.
New JUnit w/supporting files included.
Note: pom file change should not be included, my mistake.