Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding hold and unhold to feature alpha #34638

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Adding hold and unhold to feature alpha #34638

merged 7 commits into from
Apr 1, 2024

Conversation

v-vdharmaraj
Copy link
Contributor

@v-vdharmaraj v-vdharmaraj commented Mar 5, 2024 •
edited
Loading

Description

Adding hold and unhold feature to sdk User Story 3635074: [Alpha3][Python][Hold/Unhold][SDK] Add Hold/Unhold APIs.

Testing:

  1. Hold the target participant with or without the playsource for few seconds
  2. checking the is_on_hold property from the get participant => expected to be true and actual also true
  3. Unhold the target participant
  4. checking the is_on_hold property from the get participant => expected to be false and actual also false

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-callautomation

cochi2
cochi2 reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@cochi2 cochi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the async version of hold and unhold

...e-communication-callautomation/azure/communication/callautomation/_call_connection_client.py Show resolved Hide resolved
...e-communication-callautomation/azure/communication/callautomation/_call_connection_client.py Show resolved Hide resolved
...ation-callautomation/azure/communication/callautomation/aio/_call_connection_client_async.py Show resolved Hide resolved
sdk/communication/azure-communication-callautomation/tests/test_call_media_client.py Show resolved Hide resolved
@v-vdharmaraj v-vdharmaraj marked this pull request as ready for review March 14, 2024 06:36
@cochi2 cochi2 merged commit 1e44338 into main Apr 1, 2024
17 checks passed
@cochi2 cochi2 deleted the users/vdharmaraj/holdUnholdChangeAlpha branch April 1, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cochi2 cochi2 cochi2 left review comments

@Paresh-Arvind-Patil Paresh-Arvind-Patil Paresh-Arvind-Patil approved these changes

@minwoolee-msft minwoolee-msft Awaiting requested review from minwoolee-msft minwoolee-msft is a code owner

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-vdharmaraj @azure-sdk @Paresh-Arvind-Patil @cochi2