fixRetryPolicyWhenSplitHandlingDisabledForChangeFeed #40738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlian12
requested review from
kushagraThapar,
FabianMeiswinkel,
kirankumarkolli,
milismsft,
aayush3011,
simorenoh,
jeet1995 and
Pilchie
as code owners
added 2 commits
June 20, 2024 16:27
|
API change check API changes are not detected in this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
June 21, 2024 09:41
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
ChangeFeedProcessor and CosmosDB Kafka Connector use changeFeed to get all changes. Since split/merge is specifically handled in ChangeFeedProcessor and Kafka Connector itself, so we purposely want to disable the split/merge handling in azure-cosmos SDK.
However, when using ChangeFeedProcessor.disableSplitHandling, we should have only disable the split/merge retry policy, but currently it has disabled all retry policies including ClientRetryPolicy, ResourceThrottleRetryPolicy, NameCacheStaleRetryPolicy
Fix:
Only disable PartitionKeyRangeGoneRetryPolicy when disableSplitHandling