-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addingMetricsSupportInKafkaConnector #39808
addingMetricsSupportInKafkaConnector #39808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, thanks @xinlian12
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/Configs.java
Outdated
Show resolved
Hide resolved
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - kafka |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check API changes are not detected in this pull request. |
/azp run java - cosmos - kafka |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - kafka |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - cosmos - kafka |
/azp run java - cosmos - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
/check-enforcer override |
Related to #38765
Design
azure-cosmos has metrics support, and exposed multiple API so that customer can config with metrics category, tags, percentiles etc.
In kafka connector, instead of exposing those capabilities through configs, we allow customers to configure through environment variable/system properties + enable metrics collection by using java agents.
Example with use AppInsights java agent
export KAFKA_OPTS="-javaagent:$base_dir/applicationinsights-agent-3.5.1.jar -DCOSMOS.METRICS_CONFIG={\"metricCategories\":\"[OperationDetails]\"}"