Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging IndexQueryMetrics change from PR39433 #39623

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

trande4884
Copy link
Member

Merging IndexQueryMetrics to SB3 from this PR: #39433


Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

…cation.properties` configuration file (#39433)

* * Exposing the `indexQueryMetrics` to the `CosmosConfig` via the `application.properties` configuration file.

* Updating the default application.properties file.

* Updating the changelog.

* Adding repository tests.

* Fixing readme syntax

* Added more tests for query metrics and index metrics

* Adding tests for when queryMetrics disabled and indexMetrics disabled for templates.

* Adding tests for when queryMetrics disabled and indexMetrics disabled for repositories.

* Fixing Constructor Properties.

* Testing

* Testing

---------

Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com>
Updating the changelog
@trande4884
Copy link
Member Author

/azp run java - spring - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @trande4884

@trande4884 trande4884 merged commit c905b20 into feature/spring-boot-3 Apr 9, 2024
37 checks passed
@trande4884 trande4884 deleted the spring-boot--3_PR39433 branch April 9, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants