Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging PR36611 into the Spring Boot 3 Branch #37475

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Merging PR36611 into the Spring Boot 3 Branch #37475

merged 1 commit into from
Nov 1, 2023

Conversation

trande4884
Copy link
Member

  • Implementing Bulk support in Spring Data Cosmos, this currently is not working properly.

  • Reverting files I shouldn't have committed.

  • Revert "Reverting files I shouldn't have committed."

This reverts commit e6e75c6.

  • Revert "Revert "Reverting files I shouldn't have committed.""

This reverts commit c009d4a.

  • Current working solution.

  • Updates to the bulk logic, still hitting errors in the tests.

  • Fixing bugs in implementation and cleaning up code/tests.

  • Finalizing implementation and implementing for Reactive.

  • Adding tests and some more cleanup.

  • Updating changelog and cleaning up javadocs.

  • Fixing build errors.

  • Fixing build errors.

  • Fixing build errors.

  • Fixing build errors.

  • Fixing build errors.

  • Fixing spotbug errors.

  • Fixing spotbug errors.

  • Fixing revapi errors.

  • Fixing revapi errors.

  • Fixing revapi errors.

  • Fixing revapi errors.

  • Fixing revapi errors.

  • Fixing revapi errors.

  • Fixed revAPI for insertAll API

  • Finalizing revapi.

  • Fixing logic related to bulk delete and how we determine the PartitionKey.

  • Fixing unchecked cast error.

  • Removing unused import.

  • Fixing linting errors.

  • Trying to fix linting error.

  • Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md

  • Update sdk/spring/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/core/CosmosOperations.java

  • Changing function logic based on review feedback.

  • Fixing javadocs.

  • Fixing reactive saveAll logic.

  • Fixing revapi.json

  • Removing unused imports.

  • Fixing revapi.json

  • Cleaning up code after review. Adding options to both the individual operations for the bulk execution and bulk options. Also cleaning up inconsistencies and removing un-used code.

  • Fixing revapi.

  • Updating changelog. Added etag related tests which led to some small code updates.

  • Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md

  • Updates from PR requests.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@trande4884 @kushagraThapar
Bulk Implementation (Azure#36611)
db8e315 
* Implementing Bulk support in Spring Data Cosmos, this currently is not working properly.

* Reverting files I shouldn't have committed.

* Revert "Reverting files I shouldn't have committed."

This reverts commit e6e75c6.

* Revert "Revert "Reverting files I shouldn't have committed.""

This reverts commit c009d4a.

* Current working solution.

* Updates to the bulk logic, still hitting errors in the tests.

* Fixing bugs in implementation and cleaning up code/tests.

* Finalizing implementation and implementing for Reactive.

* Adding tests and some more cleanup.

* Updating changelog and cleaning up javadocs.

* Fixing build errors.

* Fixing build errors.

* Fixing build errors.

* Fixing build errors.

* Fixing build errors.

* Fixing spotbug errors.

* Fixing spotbug errors.

* Fixing revapi errors.

* Fixing revapi errors.

* Fixing revapi errors.

* Fixing revapi errors.

* Fixing revapi errors.

* Fixing revapi errors.

* Fixed revAPI for insertAll API

* Finalizing revapi.

* Fixing logic related to bulk delete and how we determine the PartitionKey.

* Fixing unchecked cast error.

* Removing unused import.

* Fixing linting errors.

* Trying to fix linting error.

* Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md

Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

* Update sdk/spring/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/core/CosmosOperations.java

Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

* Changing function logic based on review feedback.

* Fixing javadocs.

* Fixing reactive saveAll logic.

* Fixing revapi.json

* Removing unused imports.

* Fixing revapi.json

* Cleaning up code after review. Adding options to both the individual operations for the bulk execution and bulk options. Also cleaning up inconsistencies and removing un-used code.

* Fixing revapi.

* Updating changelog. Added etag related tests which led to some small code updates.

* Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md

Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

* Updates from PR requests.

---------

Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com>
Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
@github-actions github-actions bot added the azure-spring All azure-spring related issues label Nov 1, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-spring-data-cosmos

@trande4884
Copy link
Member Author

/azp run java - spring - tests

@trande4884 trande4884 self-assigned this Nov 1, 2023
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884
Copy link
Member Author

Merging #36611

@trande4884 trande4884 merged commit d78ad36 into Azure:feature/spring-boot-3 Nov 1, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@xinlian12 xinlian12 Awaiting requested review from xinlian12 xinlian12 is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@aayush3011 aayush3011 Awaiting requested review from aayush3011 aayush3011 is a code owner

@simorenoh simorenoh Awaiting requested review from simorenoh simorenoh is a code owner

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

@jeet1995 jeet1995 Awaiting requested review from jeet1995 jeet1995 is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie Pilchie is a code owner

Assignees

@trande4884 trande4884

Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trande4884 @azure-sdk @kushagraThapar