Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with returning a Flux<JsonNode> in reactive spring. #33730

Merged
merged 4 commits into from
Mar 2, 2023

Conversation

trande4884
Copy link
Member

@trande4884 trande4884 commented Feb 24, 2023

Description

Issues were introduced with annotated queries and returning Flux from Reactive Spring. Updating the ReactiveCosmosTemplate to have the same behavior as CosmosTempalte.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trande4884 trande4884 merged commit 6d92f51 into Azure:main Mar 2, 2023
@abhitwr
Copy link

abhitwr commented Mar 14, 2023

Hi All , is this fix released to PROD ? we want to start using the latest cosmos version

@xinlian12
Copy link
Member

not yet, it will go into the next release, current ETA by the end of this week. You can use use this link for tracking: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-spring-data-cosmos/CHANGELOG.md

@abhitwr
Copy link

abhitwr commented Mar 29, 2023

Hi All, can someone confirm if the fix is live ?

@kushagraThapar
Copy link
Member

@abhitwr - yes, this was released in 3.33.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues Cosmos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] IllegalArgumentException: domain should contain @Id field or field named id
6 participants